Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plot not using device labels #488

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix plot not using device labels #488

merged 2 commits into from
Mar 27, 2024

Conversation

dNechita
Copy link
Contributor

PR Description

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

@dNechita
oscplot.c: Simplify access to iio_device* from struct 'channel_settings'
8ec10df 
No need to have polymorphism here. Having a variable of type 'iio_device *' is much simpler.

Signed-off-by: Dan <[email protected]>
nunojsa
nunojsa requested changes Mar 26, 2024
View reviewed changes
osc.c Outdated Show resolved Hide resolved
@dNechita
osc: Identify iio_device by label 1st, name 2nd, id 3rd
f3e8d17 
These changes help when multiple instances of the same type of driver exist. Otherwise we end up with mutiple iio_device with the same name.

Signed-off-by: Dan <[email protected]>
@dNechita dNechita force-pushed the fix-plot-not-using-device-labels branch from 5a8b71f to f3e8d17 Compare March 26, 2024 09:15
@dNechita
Copy link
Contributor Author

V2:
Update everything (based on review suggestions) to use helper 'get_iio_device_label_or_name()'.

@dNechita dNechita requested a review from nunojsa March 26, 2024 12:16
@dNechita dNechita merged commit 0ce16d2 into main Mar 27, 2024
10 checks passed
@dNechita dNechita deleted the fix-plot-not-using-device-labels branch March 27, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristina-suteu cristina-suteu cristina-suteu approved these changes

@nunojsa nunojsa nunojsa approved these changes

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dNechita @nunojsa @cristina-suteu